Skip to content

fix: Update database URL in config and migration logic #2298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kubestellar-prow merged 3 commits into from
Jan 2, 2026
Merged

fix: Update database URL in config and migration logic #2298

kubestellar-prow merged 3 commits into from
Jan 2, 2026

Conversation

@Abhishek-Punhani
Copy link
Contributor

@Abhishek-Punhani Abhishek-Punhani commented Dec 27, 2025

Description

  • Based on the merged PR Fix: Docker Setup - Redis and Postgres Connectivity #2291 and the conversation details, it appears that the Docker Compose configuration was updated to resolve connectivity issues with the Redis and Postgres containers.
    However, the default config values in config.go were not changed, which is causing errors during the default backend startup.
  • Also in migrate.go, the PostgreSQL URL was directly fetched from os.env, which should have been from the config file to handle the default env configurations in case env vars are not set

Related Issue

Fixes #2297

Changes Made

  • Updated config.go , migrate.go

Checklist

Please ensure the following before submitting your PR:

  • I have reviewed the project's contribution guidelines.
  • I have written unit tests for the changes (if applicable).
  • I have updated the documentation (if applicable).
  • I have tested the changes locally and ensured they work as expected.
  • My code follows the project's coding standards.

Screenshots or Logs (if applicable)

Additional Notes

Copilot AI review requested due to automatic review settings December 27, 2025 18:46
@kubestellar-prow
Copy link

kubestellar-prow bot commented Dec 27, 2025

Hi @Abhishek-Punhani. Thanks for your PR.

I'm waiting for a kubestellar member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubestellar-prow kubestellar-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 27, 2025
@github-actions github-actions bot added backend Issues or PRs related to the low-level API machinery for KubeStellar and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 27, 2025
Copilot AI reviewed Dec 27, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes database connectivity issues by updating the default database name from authdb to authdbui and refactoring the migration logic to use the centralized config package instead of directly accessing environment variables.

Key Changes:

  • Updated default PostgreSQL database name in config to match Docker Compose configuration
  • Refactored migration logic to use config.LoadConfig() instead of os.Getenv() for consistency

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
backend/pkg/config/config.go Updated default database URL to use authdbui instead of authdb to align with Docker Compose setup
backend/postgresql/migrate.go Replaced direct os.Getenv() calls with config.LoadConfig() for centralized configuration management

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kubestellar-prow kubestellar-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 27, 2025
Copilot AI reviewed Dec 27, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Nupurshivani
Copy link
Contributor

Nupurshivani commented Dec 29, 2025

/ok-to-test

@kubestellar-prow kubestellar-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 29, 2025
@Abhishek-Punhani
Copy link
Contributor Author

Abhishek-Punhani commented Dec 30, 2025

/retest-required

@Abhishek-Punhani
Copy link
Contributor Author

Abhishek-Punhani commented Dec 30, 2025

Tests are passing now. Ig we can merge this one now?

@onkar717
Copy link
Contributor

onkar717 commented Jan 1, 2026

@btwshivam we can merge this !

@github-project-automation github-project-automation bot moved this from In Progress to Ready to Merge in KubeStellar UI Project Jan 2, 2026
@kubestellar-prow kubestellar-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2026
@kubestellar-prow
Copy link

kubestellar-prow bot commented Jan 2, 2026

LGTM label has been added.

DetailsGit tree hash: e65d0ed0a3c71c5ec0b0a2157567ef89af3956f7

@btwshivam
Copy link
Contributor

btwshivam commented Jan 2, 2026

/ok-to-test
/approve
/lgtm

@kubestellar-prow
Copy link

kubestellar-prow bot commented Jan 2, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: btwshivam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2026
@kubestellar-prow kubestellar-prow bot merged commit a04bd64 into kubestellar:dev Jan 2, 2026
10 checks passed
@github-project-automation github-project-automation bot moved this from Ready to Merge to Done in KubeStellar UI Project Jan 2, 2026
This was referenced Jan 2, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@btwshivam btwshivam btwshivam approved these changes

Assignees

@btwshivam btwshivam

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backend Issues or PRs related to the low-level API machinery for KubeStellar lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

KubeStellar UI Project
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Incorrect Fallback URL in config and Migration Code Ignores Default DATABASE_URL Fallback in Config

4 participants

@Abhishek-Punhani @Nupurshivani @onkar717 @btwshivam